-
Notifications
You must be signed in to change notification settings - Fork 39
Lite: Fix repeater button styling in form builder #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ctor SCSS nesting
|
Warning Rate limit exceeded@shervElmi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 24 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughRemoved global button-specific selectors and refactored Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Also @shervElmi, It looks like the icon buttons are using other styles still.
|
@Crabcyborg the PR also includes Pro changes, and you can find the Pro PR in the description. |
|
@shervElmi That's only a size change? I'm seeing issues with colour. |
|
@shervElmi If I have that branch checked out, it still doesn't reflect the icon I have selected in my style. I'm wondering if we want to bother with parts of this update though. The builder isn't really 100% the same as the style. Since the builder does not have a background colour, we don't really want to show a white button here in the builder. I think we should at least show the right icon though, since that shouldn't cause any issues.
|
|
@Crabcyborg, I just want to make sure we are on the same page. If a user changes the Repeater field icons, do you want me to use that icon in the Form Builder as well, where we build forms and not on the Style page? If yes, with the icon you selected, the same background will appear in the Form Builder, and the frontend also have a background for that icon since the icon itself includes one. Could you please clarify what you would like me to do exactly, aside from moving the styles to builder.css in the Pro add on? I have applied the icon you selected in the Form Builder page to illustrate what it would look like with that icon:
|
|
@shervElmi I think it would be best if we showed the repeater icons on both pages. The styler already supports this, but the builder doesn't. We can also apply some style settings. I just don't think we should modify colour, as it's at risk of causing visibility issues. |
|
@Crabcyborg, this PR and the related Pro PR are ready to merge. The buttons styles are now consistent across all pages, including the Builder, Style, and frontend. Builder Page
Style Page
Frontend
|






Fixes https://github.com/Strategy11/formidable-pro/issues/6142
Updated the repeater Add/Remove buttons in the form builder to match the form preview.
Add-ons Changes