Pass email object to frm_notification hook

[AbdiTolesa]

Required for: https://github.com/Strategy11/formidable-logs/pull/54

[coderabbitai]

Walkthrough

The frm_notification action hook in FrmEmail.php now receives an additional parameter—the FrmEmail object itself as the fourth argument—expanding the data available to hook listeners without modifying other logic.

Changes

Cohort / File(s)	Summary
Modified email notification hook classes/models/FrmEmail.php	Updated frm_notification action to pass FrmEmail object ($this) as the fourth parameter to listeners

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Backwards compatibility consideration: Verify existing listeners of the frm_notification hook can handle the additional parameter gracefully
• Parameter documentation: Check if hook documentation or inline comments need updates to reflect the new parameter signature

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether a description exists that relates to the changeset.	Add a pull request description explaining the purpose and impact of passing the email object to the frm_notification hook.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Pass email object to frm_notification hook' directly and clearly describes the main change in the PR: adding the FrmEmail object as a parameter to the frm_notification action hook.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add_email_object_to_frm_notification_hook

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

classes/models/FrmEmail.php (1)

584-584: Passing the FrmEmail instance into frm_notification looks good; consider documenting the new param

Adding $this as a 4th argument usefully exposes the full email context to hook consumers and is an additive change, so behaviorally this looks solid. To make this easier for integrators to discover and to clarify the argument order, consider adding or updating a docblock above this do_action (or in your developer docs) to list all four parameters and note the version when the email object was introduced.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 016dae5 and da22e9e.

📒 Files selected for processing (1)

• classes/models/FrmEmail.php (1 hunks)