Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/admin/frm-settings-components.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/frm_admin.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/frm_testing_mode.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/addons-page.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/form-templates.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/form-templates.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable-settings-components.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable-settings-components.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable_admin.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable_admin.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable_blocks.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable_dashboard.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable_dashboard.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/formidable_overlay.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion js/formidable_styles.js

Large diffs are not rendered by default.

6 changes: 1 addition & 5 deletions js/formidable_styles.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/frm_testing_mode.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/onboarding-wizard.js

Large diffs are not rendered by default.

52 changes: 44 additions & 8 deletions js/src/admin/admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -4533,6 +4533,49 @@ window.frmAdminBuildJS = function() {
destroyFieldGroupPopup();
}

/**
* Get an array of fields that are selected.
*
* @since x.x
*
* @param {Object} $firstGroup
* @param {HTMLElement} hoverTarget
*
* @returns {Object}
*/
function getSelectedRange( $firstGroup, hoverTarget ) {
const hoverTargetSection = hoverTarget.closest( '.edit_field_type_divider' );
let targetSection, $range, fieldsInSection;
if ( hoverTargetSection ) {
targetSection = hoverTargetSection.closest( 'ul' ).closest( '.frm_field_box.ui-draggable' );
fieldsInSection = [ ...hoverTargetSection.querySelectorAll( '.frm_field_box.ui-draggable' ) ].filter( el => el.classList.length === 2 );
}
const hoverTargetBox = hoverTarget.closest( 'li' );
if ( $firstGroup.parent().index() < jQuery( targetSection || hoverTarget.parentNode ).index() ) {
// If field target field is in a section.
$range = $firstGroup.parent().nextUntil( targetSection || hoverTarget.parentNode );

if ( ! fieldsInSection ) {
return $range;
}
$range = $range.add( fieldsInSection.slice( 0, fieldsInSection.indexOf( hoverTargetBox ) + 1 ) );
return $range;
}

// Select fields back to the first group.
if ( targetSection?.contains( $firstGroup.get( 0 ) ) ) {
$range = $firstGroup.parent().prevUntil( hoverTarget.parentNode );
} else {
$range = $firstGroup.parent().prevUntil( targetSection || hoverTarget.parentNode );
}
if ( ! fieldsInSection ) {
return $range;
}
$range = $range.add( fieldsInSection.slice( -( fieldsInSection.length - fieldsInSection.indexOf( hoverTargetBox ) ) ) );

return $range;
}

function fieldGroupClick( e ) {
maybeShowFieldGroupMessage();

Expand Down Expand Up @@ -4577,14 +4620,7 @@ window.frmAdminBuildJS = function() {
++numberOfSelectedGroups; // include the one we're selecting right now.
const $firstGroup = $selectedFieldGroups.first();

let $range;
if ( $firstGroup.parent().index() < jQuery( hoverTarget.parentNode ).index() ) {
$range = $firstGroup.parent().nextUntil( hoverTarget.parentNode );
} else {
$range = $firstGroup.parent().prevUntil( hoverTarget.parentNode );
}

$range.each(
getSelectedRange( $firstGroup, hoverTarget ).each(
function() {
const $fieldGroup = jQuery( this ).closest( 'li' ).find( 'ul.frm_sorting' );
if ( ! $fieldGroup.hasClass( 'frm-selected-field-group' ) ) {
Expand Down