-
Notifications
You must be signed in to change notification settings - Fork 39
Project: Add option to limit field choices selection #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AbdiTolesa
wants to merge
123
commits into
master
Choose a base branch
from
limit_choices_selection_lite_part
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+166
−15
Open
Changes from 12 commits
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
419db81
Add option to limit field choices selection
AbdiTolesa 131c38a
Refactor function
AbdiTolesa 795be68
Add disable attribute to radio fields based on choice limit setting
AbdiTolesa bd9f947
Do not check disabled checkbox
AbdiTolesa 191299f
Cover dropdown field for choice limit checks
AbdiTolesa e4fd076
Do not disable choices in builder
AbdiTolesa ea2ea27
Try reusing frm_field_input_html to output disabled html att
AbdiTolesa 055c1b7
Hide/Disable field choices that hit max entry based off the form sett…
AbdiTolesa de943ef
Committing progress
AbdiTolesa 06102a9
Fix some style errors
AbdiTolesa c6872b7
Revert some changes
AbdiTolesa fcf9770
Hide/Disable choices based off the new setting
AbdiTolesa 5613edd
Remove extra function param passed to FrmFieldsController::maybe_disa…
AbdiTolesa 4e097eb
Add latest field choice output updates to dropdown field
AbdiTolesa acb7bd1
Make function and variables more descriptive for choice limit check l…
AbdiTolesa 9a3ff48
Fix merge conflicts
AbdiTolesa 55c4931
Sync js files with master
AbdiTolesa 53f1676
Sync js files with master
AbdiTolesa 5931cad
Sync js files with master
AbdiTolesa 9ac0c74
Move function from Pro to Lite
AbdiTolesa 8bef115
Resolve dependency on Pro
AbdiTolesa b376cda
Fix workflow errors
AbdiTolesa da17e00
Reduce PHP logic in view files
AbdiTolesa b7b357a
Move function that fetches form option into Pro
AbdiTolesa ad7e2c2
Avoid outputting <select> tag if all choices have hit their limit for…
AbdiTolesa e367bcf
Move code that should be in Pro to there
AbdiTolesa 3b8a3df
Add choice limit reached validation message to helper function
AbdiTolesa 6d48545
Cover other field types for showing new message
AbdiTolesa e8aac0c
Change default message for choice limit reached
AbdiTolesa c497327
Change array_filter calls to foreach
AbdiTolesa 78ad919
Use current() to simplify complicated code
AbdiTolesa c7709ea
Fix merge conflict
AbdiTolesa 574fd74
Merge branch 'master' into limit_choices_selection_lite_part
AbdiTolesa 05f367a
Fix potential bugs
AbdiTolesa 6020eaf
Fix missing variable warning
AbdiTolesa 6ec1d1c
Fix potential bug
AbdiTolesa 9986575
Add comment to new action
AbdiTolesa f11b7ac
Merge master
AbdiTolesa 5050456
Add a couple of enhancements
AbdiTolesa 1d7d8e4
Fix limit input element getting selected when it shouldn't
AbdiTolesa 2ad0655
Make sure maxed out options are not reset on entry submit
AbdiTolesa 20976b9
Add a new hook frm_should_echo_disabled_attribute
AbdiTolesa bf4e6a3
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg 3fe4eeb
Tweak label query
Crabcyborg 799de54
Fix issue with other options not getting added
Crabcyborg 8c5c69f
Do some code refactoring
AbdiTolesa 645aada
Merge branch 'limit_choices_selection_lite_part' of https://github.co…
AbdiTolesa e1e3244
Do some code refactoring
AbdiTolesa cda61bb
Add filter that allows updating field default validation messages
AbdiTolesa 7c62ffe
Update new filter param comment
AbdiTolesa 0946032
Fix potential condition check bug
AbdiTolesa db23bfc
Align array arrows
AbdiTolesa e953057
Add missing function descriptions
AbdiTolesa 471f39b
Move should_hide_field_choice method to FrmFieldsHelper
AbdiTolesa 01de971
Move FrmFieldsController::should_echo_disabled_attribute to FrmFields…
AbdiTolesa 52d85eb
Move more functions and shorten a function param
AbdiTolesa 15b47f6
Fix a potential bug
AbdiTolesa db58a4e
Delete return type declaration for a filter
AbdiTolesa c6d5edd
Fix merge conflict
AbdiTolesa 4a385b3
Build files
AbdiTolesa ae6be8a
Address potential bugs and improve code related to choice limit feature
AbdiTolesa 06418cb
Move more choices limit feature related code to Pro
AbdiTolesa 2ed2690
Move more code from Lite to Pro
AbdiTolesa 50f3d5f
Refactor code to simplify logics in view files
AbdiTolesa 242c12a
Delete code not needed in Lite
AbdiTolesa c8f792d
Merge branch 'master' into limit_choices_selection_lite_part
AbdiTolesa d74ef56
Merge branch 'master' into limit_choices_selection_lite_part
AbdiTolesa bce1dc3
Clean up stubs.php
AbdiTolesa 7b49acb
Add a missing ?? check
AbdiTolesa 994471e
Fix a PHP doc separation check error
AbdiTolesa dc09bc3
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg 9057e3d
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg 87f0ec0
Cast to bool
AbdiTolesa c2786f5
Fix merge conflicts
AbdiTolesa cc787a3
Cast to bool
AbdiTolesa e347397
Merge branch 'master' into limit_choices_selection_lite_part
AbdiTolesa efc359a
Fixed code style with PHP CS Fixer
AbdiTolesa 338cd21
Fixed code style with PHP CS Fixer
AbdiTolesa fcbca46
Reduce opacity for disabled inputs
AbdiTolesa 7d783ee
Support showing remaining choice entries
AbdiTolesa cba9039
Support showing remaining choices for image formatted choices
AbdiTolesa 03c62b2
Pass extra param to frm_choice_field_option_label filter
AbdiTolesa 2e899fb
Merge master
AbdiTolesa 6472959
Add missing param needed for showing remaining choice entries
AbdiTolesa eca4902
Fix code style errors
AbdiTolesa 43b7e71
Simplify and refactor functions
AbdiTolesa 32b0c04
Avoid inline comment
AbdiTolesa 638848b
Add a field setting that allows controlling whether remaining options…
AbdiTolesa 1200b96
Add field settings to customize choice limit messages
AbdiTolesa b35fe1a
Merge master and rebuild files
AbdiTolesa 21c1222
Merge master and rebuild files
AbdiTolesa 038f926
Fix merge conflicts and merge master
AbdiTolesa 77e0861
Fix remaining merge conflict
AbdiTolesa 4b86627
Fix codestyle issues
AbdiTolesa 5667907
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg b86c871
Drop map files
Crabcyborg 626562e
Reduce repeated code and delete Pro related style
AbdiTolesa 580a932
Merge branch 'limit_choices_selection_lite_part' of https://github.co…
AbdiTolesa 32c41c5
Fix broken PHPCS rule
AbdiTolesa a240155
Make filter name more generic
AbdiTolesa c86c146
Move more Pro related to Pro
AbdiTolesa cd6b75f
Change variable names and fix function description comments
AbdiTolesa b1361c0
Add missing $ symbol
AbdiTolesa 1fd31a8
Group functions together
AbdiTolesa a39eb33
Fix merge conflict with master and merge master
AbdiTolesa 6341144
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg a5f8d0b
Use kses echo (merge conflict error)
Crabcyborg 39946a5
Update param type in filter description
AbdiTolesa 14e0f06
Fix static analysis error
AbdiTolesa 75eb854
Try alternative way to reuse echo_dropdown_option
AbdiTolesa 23f215c
Align function params spacing
AbdiTolesa 5ba0a83
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg 699093d
Address some comments
AbdiTolesa 1e011ec
Merge branch 'limit_choices_selection_lite_part' of https://github.co…
AbdiTolesa 00c8bed
Add missing variable name from filter params description comment
AbdiTolesa d382ac5
Merge branch 'master' into limit_choices_selection_lite_part
Crabcyborg 6c64a19
Change function name
AbdiTolesa d11b8af
Merge branch 'limit_choices_selection_lite_part' of https://github.co…
AbdiTolesa 9537362
Change function name to make it more descriptive
AbdiTolesa 507066a
Update function comment
AbdiTolesa 59e3bc7
Change function name for consistency
AbdiTolesa 478dbfd
Make hook and function names consistent
AbdiTolesa 23abbdc
Make hook name consistent
AbdiTolesa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.