Skip to content

Clarify that "errors" are not fatal #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sainan wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Clarify that "errors" are not fatal #649

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbfee52
Update ContentDownloader.cs
Sainan Aug 31, 2025
0dbdecb
Update ContentDownloader.cs
Sainan Aug 31, 2025
e1ece75
Update DepotDownloader/ContentDownloader.cs
Sainan Sep 1, 2025
6cb0ffe
Update ContentDownloader.cs
Sainan Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions DepotDownloader/ContentDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ private static async Task<DepotFilesData> ProcessDepotManifestAndFiles(Cancellat
break;
}

Console.WriteLine("Encountered error downloading depot manifest {0} {1}: {2}", depot.DepotId, depot.ManifestId, e.StatusCode);
Console.WriteLine("Encountered {2} for depot manifest {0} {1}. Retrying.", depot.DepotId, depot.ManifestId, e.StatusCode);
Copy link
Member

@yaakov-h yaakov-h Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Console.WriteLine("Encountered {2} for depot manifest {0} {1}. Retrying.", depot.DepotId, depot.ManifestId, e.StatusCode);
Console.WriteLine("Encountered HTTP {2:D} for depot manifest {0} {1}. Retrying.", depot.DepotId, depot.ManifestId, e.StatusCode);

}
catch (OperationCanceledException)
{
Expand All @@ -843,7 +843,7 @@ private static async Task<DepotFilesData> ProcessDepotManifestAndFiles(Cancellat
catch (Exception e)
{
cdnPool.ReturnBrokenConnection(connection);
Console.WriteLine("Encountered error downloading manifest for depot {0} {1}: {2}", depot.DepotId, depot.ManifestId, e.Message);
Console.WriteLine("Error downloading manifest for depot {0} {1}: {2} Retrying.", depot.DepotId, depot.ManifestId, e.Message);
Copy link
Member

@yaakov-h yaakov-h Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Console.WriteLine("Error downloading manifest for depot {0} {1}: {2} Retrying.", depot.DepotId, depot.ManifestId, e.Message);
Console.WriteLine("Error downloading manifest for depot {0} {1}: {2} Retrying...", depot.DepotId, depot.ManifestId, e.Message);

}
} while (newManifest == null);

Expand Down Expand Up @@ -1258,7 +1258,7 @@ private static async Task DownloadSteam3AsyncDepotFileChunk(
break;
}

Console.WriteLine("Encountered error downloading chunk {0}: {1}", chunkID, e.StatusCode);
Console.WriteLine("Encountered {1} for chunk {0}. Retrying.", chunkID, e.StatusCode);
Copy link
Member

@yaakov-h yaakov-h Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Console.WriteLine("Encountered {1} for chunk {0}. Retrying.", chunkID, e.StatusCode);
Console.WriteLine("Encountered HTTP {1:D} for chunk {0}. Retrying...", chunkID, e.StatusCode);

Copy link
Author

@Sainan Sainan Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not gonna be work out, because StatusCode is a value like ServiceUnavailable or NotFound from what I've observed.

Copy link
Member

@yaakov-h yaakov-h Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the integer value (:D e.g. 503), or the enum name (:G eg ServiceUnavailable)?

Copy link
Author

@Sainan Sainan Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Encountered ServiceUnavailable makes more sense and keeps it roughly identical to what it was. Encountered HTTP 503 doesn't mean a whole lot to anyone who hasn't studied the HTTP RFCs.

}
catch (OperationCanceledException)
{
Expand All @@ -1267,7 +1267,7 @@ private static async Task DownloadSteam3AsyncDepotFileChunk(
catch (Exception e)
{
cdnPool.ReturnBrokenConnection(connection);
Console.WriteLine("Encountered unexpected error downloading chunk {0}: {1}", chunkID, e.Message);
Console.WriteLine("Error downloading chunk {0}: {1} Retrying.", chunkID, e.Message);
Copy link
Member

@yaakov-h yaakov-h Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Console.WriteLine("Error downloading chunk {0}: {1} Retrying.", chunkID, e.Message);
Console.WriteLine("Error downloading chunk {0}: {1} Retrying...", chunkID, e.Message);

}
} while (written == 0);

Expand Down