Skip to content

fix incorrect debug assertion in HGETEX; no impact to release build #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 2 commits into from
Jan 23, 2026
Merged

fix incorrect debug assertion in HGETEX; no impact to release build #2999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a4b2e7
fix incorrect debug assertion in HGETEX; no impact to release build
mgravell Jan 23, 2026
cee8bbb
add release note
mgravell Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ Current package versions:
| ------------ | ----------------- | ----- |
| [![StackExchange.Redis](https://img.shields.io/nuget/v/StackExchange.Redis.svg)](https://www.nuget.org/packages/StackExchange.Redis/) | [![StackExchange.Redis](https://img.shields.io/nuget/vpre/StackExchange.Redis.svg)](https://www.nuget.org/packages/StackExchange.Redis/) | [![StackExchange.Redis MyGet](https://img.shields.io/myget/stackoverflow/vpre/StackExchange.Redis.svg)](https://www.myget.org/feed/stackoverflow/package/nuget/StackExchange.Redis) |

## unreleased

- Fix incorrect debug assertion in `HGETEX` (no impact to release library) ([#2999 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2999))

## 2.10.1

- Support Redis 8.4 CAS/CAD operations (`DIGEST`, and the `IFEQ`, `IFNE`, `IFDEQ`, `IFDNE` modifiers on `SET` / `DEL`)
Expand Down
7 changes: 3 additions & 4 deletions src/StackExchange.Redis/RedisDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,9 @@ private Message HashFieldGetAndSetExpiryMessage(in RedisKey key, RedisValue[] ha
return HashFieldGetAndSetExpiryMessage(key, in hashFields[0], expiry, flags);
}

// precision, time, FIELDS, hashFields.Length
// precision, time, FIELDS, hashFields.Length, {N x fields}
int extraTokens = expiry.TokenCount + 2;

RedisValue[] values = new RedisValue[expiry.TokenCount + 2 + hashFields.Length];
RedisValue[] values = new RedisValue[extraTokens + hashFields.Length];

int index = 0;
// add PERSIST or expiry values
Expand All @@ -528,7 +527,7 @@ private Message HashFieldGetAndSetExpiryMessage(in RedisKey key, RedisValue[] ha
values[index++] = RedisLiterals.FIELDS;
values[index++] = hashFields.Length;
// check we've added everything we expected to
Debug.Assert(index == extraTokens + hashFields.Length);
Debug.Assert(index == extraTokens, $"token mismatch: {index} vs {extraTokens}");

// Add hash fields to the array
hashFields.AsSpan().CopyTo(values.AsSpan(index));
Expand Down
Loading