fix: threadlocal memory leak in yaml configuration loader #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
approved these changes
Apr 20, 2025
zml2008
force-pushed
the
fix/threadlocal-memory-leak
branch
from
3a2128d to
e5d0211
Compare
PimvanderLoos
pushed a commit
to PimvanderLoos/Configurate
that referenced
this pull request
Jul 5, 2025
…red#565) * fix: threadlocal memory leak in yaml configuration loader * chore(yaml): resolve style violations --------- Co-authored-by: zml <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained on Discord:
The YAML configuration loader uses a unique threadlocal per loader instance. This leads to the Yaml instances sitting around for as long as the thread lives, even if the yaml config loader is no longer used or even gc'd.
This PR fixes that issue by moving away from a thread local and just creating the Yaml instance when we need it.