JS-536 Fix S6957: Coerce React version ranges to valid semver #6118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the React version in package.json contains a range (e.g., "^18.0.0"), eslint-plugin-react would output a warning because it expects a valid semver version, not a range. Fix: Use semver.minVersion() to coerce version ranges to the minimum valid version that satisfies the range. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
^18.0.0)semver.minVersion()to coerce version ranges to valid semver versionsProblem
When package.json contains:
{ "dependencies": { "react": "^18.0.0" } }eslint-plugin-react would output a warning because it expects a valid semver version, not a range.
Solution
Coerce the version range to the minimum version that satisfies it:
^18.0.0→18.0.0>=17.0.0→17.0.018.2.0→18.2.0(exact versions unchanged)Fixes https://sonarsource.atlassian.net/browse/JS-536
Test plan
^18.0.0)🤖 Generated with Claude Code