AB#37206 - Show multiple labels for FCC Broadband Facts.#204
Merged
paulmaclean merged 4 commits intomasterfrom Aug 5, 2025
Merged
Conversation
![thrall-s-all-seeing-eye[bot]](https://avatars.githubusercontent.com/in/103584?s=60&v=4){kind=small}
HellooooNewman
requested changes
Jun 25, 2025
Contributor
HellooooNewman
left a comment
HellooooNewman
left a comment
There was a problem hiding this comment.
Everything else looks good otherwise.
paulmaclean
changed the base branch from
master
to
ab36699-tie_additional_services_sub_feature
paulmaclean
changed the base branch from
ab36699-tie_additional_services_sub_feature
to
master
HellooooNewman
approved these changes
Aug 5, 2025
paulmaclean
deleted the
ab37206-tie__customer_portal__display_all_fcc_nutrition_labels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Billing Controller to return multiple svgs (per data service on the account). In addition, I noticed the original
file_get_contentswas a touch slow to load the page. Instead I am returning the path and letting the template render the img from the assets path. I did notice a similar patter elsewhere - e.g:<img class="logo-form" src="/assets/img/logo.png">so I am assuming this is safe to do.