Skip to content

fix: add forward ref on select and select-async #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DiogoAbu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: add forward ref on select and select-async #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec7424
fix: add forward ref on select-async
DiogoAbu Mar 2, 2023
d3fe526
fix: add forward ref on select
DiogoAbu Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/molecules/select/select-async.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import noop from 'lodash/noop'
import React, { FC } from 'react'
import React, { FC, forwardRef } from 'react'
import ReactAsyncSelect, { AsyncProps } from 'react-select/async'
import Select from 'react-select/base'
import * as theme from '../../theme'
import { cssClass, filterStyles, selectStyles } from '../../utils'

Expand All @@ -10,7 +11,7 @@ interface SelectProps extends AsyncProps<unknown, boolean, any> {
variant?: 'default' | 'filter'
}

export const SelectAsync: FC<SelectProps> = (props) => {
export const SelectAsync: FC<SelectProps> = forwardRef<Select<any, boolean, any>, SelectProps>((props, ref) => {
const { value, onChange, variant, ...selectProps } = props
const styles = variant === 'filter' ? filterStyles(theme) : selectStyles(theme)

Expand All @@ -26,9 +27,10 @@ export const SelectAsync: FC<SelectProps> = (props) => {
onChange={handleChange}
isClearable
{...selectProps}
ref={ref}
/>
)
}
})

SelectAsync.defaultProps = {
variant: 'default',
Expand Down
10 changes: 6 additions & 4 deletions src/molecules/select/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import noop from 'lodash/noop'
import React, { FC } from 'react'
import ReactSelect, { Props } from 'react-select'
import React, { FC, forwardRef } from 'react'
import ReactSelect, { GroupBase, Props } from 'react-select'
import SelectType from 'react-select/base'
import * as theme from '../../theme'
import { cssClass, filterStyles, selectStyles } from '../../utils'

Expand All @@ -10,7 +11,7 @@ interface SelectProps extends Props {
variant?: 'default' | 'filter'
}

export const Select: FC<SelectProps> = (props) => {
export const Select: FC<SelectProps> = forwardRef<SelectType<any, boolean, GroupBase<unknown>>, SelectProps>((props, ref) => {
const { value, onChange, variant, ...selectProps } = props
const styles = variant === 'filter' ? filterStyles(theme) : selectStyles(theme)

Expand All @@ -26,9 +27,10 @@ export const Select: FC<SelectProps> = (props) => {
onChange={handleChange}
isClearable
{...selectProps}
ref={ref}
/>
)
}
})

Select.defaultProps = {
variant: 'default',
Expand Down