Comet 1/ao #300
Open
Comet 1/ao #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reads in the lpc file, converts to KEP to check a values, if they're too small (indicating a short period comet) remove that data.
First draft of the code, there are a few edge cases to work out still
Switching to pure rebound is still a work in progress, but if the comet remains inside the timeframe of the assist ephemeris then the program works as intended
Also cleaned up the code further, now converting to rebound works as expected.
Each test has its own file to read in and a file of expected values too
Changed the order of arguments in the functions so they're the same, made changes to for loops to make them more pythonic (also switched to storing output data as a dict for the same reason), made the tolerances on some unit tests smaller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Added functionality to compute 1/a0 values for comets by backwards (or forwards, if necessary) integrating using an assist simulation (or rebound, if the simulation goes outside the assist timeframe). Includes a demo for layup comet.
Review Checklist for Source Code Changes