Matter Media: Account for MinLevel and MaxLevel for volume control #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit 4390be1. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4390be1 |
This change accounts for the MinLevel and MaxLevel attributes when converting between level values used by the device and percentage values used in the audioVolume capability.
nickolas-deboom
force-pushed
the
fix/matter-media-account-for-min-and-max-volume-levels
branch
from
9ec90e4 to
4390be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change accounts for the
MinLevelandMaxLevelattributes when converting between level values used by the device and percentage values used by theaudioVolumecapability.