-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: support multi-arch builds via matrix strategy #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update planner.py to generate (package, arch) matrix. - Update build.py and builder.py to accept single architecture target. - Update metadata.py to dynamically handle multiple architectures in repository index. - Update site_generator.py to support architecture filtering, modern UI, and standard apt config in install script. - Update build.yml to utilize new matrix strategy and arch-specific artifact naming. - Ensure caching handles both arch-specific and arch-all packages.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Update site_generator.py to include 'Section' and 'Installed-Size' in metadata. - Redesign install box with terminal style and manual setup details. - Improve responsiveness and styling for various devices. - Refactor install script to use standard apt configuration. - Cleanup dead code in size formatting logic.
- Update builder.py to append architecture to log and summary filenames. - Update build.yml to capture arch-specific logs and rename build jobs. - Update jules_init.sh to include jq, file, requests, and playwright.
- Update fetcher.py to accept architecture argument and download correct index/debs. - Update builder.py to pass target arch to fetcher and strictly match artifacts in ensure_dependency. - Update run_docker_test.sh to select docker image based on target architecture (TERMUX_ARCH). - Update runtime_test_runner.sh to extract arch from deb filename and export TERMUX_ARCH.
- Update builder.py to use output/sysroot-{arch} to prevent lib pollution.
- Update coreutils/build.sh to disable year2038 for 32-bit targets.
- Ensure test runner receives correct arch env.
- Export TERMUX_ARCH in scripts/build_engine/entry_point.sh. - Ensures correct architecture detection in coreutils build script and runtime tests.
- Create coreutils_shim.h in pre_configure to define mktime_z using mktime. - Include shim via CPPFLAGS to resolve implicit declaration errors.
- Update packages/coreutils/build.sh to use termux_step_post_configure. - Append #define mktime_z... directly to lib/config.h instead of using CPPFLAGS. - Remove ineffective CPPFLAGS shim logic.
Implemented multi-architecture support (aarch64, arm) using separate matrix jobs in GitHub Actions. This involved refactoring the planner to explode package-arch pairs, updating the builder to handle single-arch builds and caching, enhancing the metadata generator to index multiple architectures dynamically, and modernizing the site generator for better UX and correct apt configuration. The install script now uses standard Debian repository syntax.
PR created automatically by Jules for task 16959691027110786030 started by @SjnExe