fix(openapi): integer types should be i64
#47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Pull Request
📝 Description
Relates to this issue. The codegen that produces our internal client was converting OpenAPI integer types to
i32. This caused certain fields within the circuit info response to overflow and deserialization of those responses failed in an opaque way.🔗 Related Tickets & Documents
📋 Type of PR (check all applicable)
💭 Developer Notes
The main content in this PR is within the api update script:
This is a broader surface area than just circuit details and will apply to any future API update. There are minor performance implications, but I cannot think of any current use cases where the involved API fields overwhelm memory. It is much more likely that a different user will encounter issues with e.g. pagination
🧪 Testing Instructions
Groth16 Sp1 program circuit detail deserialized successfully
✅ Testing Status