Skip to content

Conversation

@katiemckeon
Copy link
Collaborator

🔄 Pull Request

📝 Description

Relates to this issue. The codegen that produces our internal client was converting OpenAPI integer types to i32. This caused certain fields within the circuit info response to overflow and deserialization of those responses failed in an opaque way.

🔗 Related Tickets & Documents

  • Related Issue #
  • Closes #

📋 Type of PR (check all applicable)

  • 🔨 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • ⚡ Optimization
  • 📚 Documentation Update

💭 Developer Notes

The main content in this PR is within the api update script:

# Patch OpenAPI generator problematic integer->i32 conversion
sed -i 's/i32/i64/g' openapi/src/models/*.rs

This is a broader surface area than just circuit details and will apply to any future API update. There are minor performance implications, but I cannot think of any current use cases where the involved API fields overwhelm memory. It is much more likely that a different user will encounter issues with e.g. pagination

🧪 Testing Instructions

Groth16 Sp1 program circuit detail deserialized successfully

✅ Testing Status

  • Yes, tests added/updated. (Unit tests touching the circuit info response now include an i64 value)
  • No tests needed because: please explain why
  • Help needed with testing

@katiemckeon katiemckeon merged commit 10d8a9d into main Jul 21, 2025
1 check passed
@katiemckeon katiemckeon deleted the klm-patch-autogen-i32-issue branch July 21, 2025 21:14
This was referenced Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants