Conversation
Create scripts to generate targets.json for 2023-10 API version: - Admin: 16 targets, 28 components - Checkout: 52 targets, 47 components Updated build-docs.sh to call the targets scripts.
b055f5e to
b67affd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Part of: https://github.com/Shopify/shopify-dev/issues/66648
We want to parse target information for the dev docs for each surface.
Solution
Added scripts for admin and checkout surfaces to pull target information into a format that shopify-dev needs to display that information.
Note: This is the 2023-10 API version branch. Only admin and checkout surfaces exist on this branch (no point-of-sale or customer-account as separate surfaces).
The scripts handle:
@privateJSDoc tags: Targets marked with@privateare excluded from the generated outputPick<>/Omit<>types: Correctly resolved to their component listsRenderExtension<Api, Components>definitionsKey differences for 2023-10:
extension-targets.tswithExtensionTargetsinterfacetargets.tswithExtensionTargetsinterface.naming (e.g.,purchase.checkout.block.render) and deprecated::naming (e.g.,Checkout::Dynamic::Render)🎩
Run the docs generation scripts (which now include targets.json generation):
Verify that:
@privateexcluded:Playground)@privateexcluded including gift card and payment method targets)componentsandapisarraysChecklist