Simplify ProductTaxonomy::Loader API to use data_path#853
Open
Simplify ProductTaxonomy::Loader API to use data_path#853
Conversation
hadijafar
changed the title
hadijafar
force-pushed
the
updating-data_path-in-loader-class
branch
from
995c19f to
3480360
Compare
hadijafar
changed the title
hadijafar
force-pushed
the
updating-data_path-in-loader-class
branch
from
3480360 to
53d5a11
Compare
hadijafar
requested review from
JeffrayZhang,
KaiKitJeffreyChan,
Stivaros,
danielpgross,
jmignac and
ricardotejedorsanz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify ProductTaxonomy::Loader interface
This PR simplifies the
ProductTaxonomy::Loader.loadmethod by accepting a singledata_pathparameter instead of requiring individual file paths. The loader now constructs all necessary file paths internally based on the provided data directory.The change reduces code duplication across the codebase by centralizing the file path construction logic in the loader class itself. This makes the API more straightforward to use and ensures consistent file path handling.
Version bumped to 1.1.0 to reflect this interface change.
look at this pr for more context