Add specs for include bracket/dot access, liquid tag, and multiline if#125
Open
Add specs for include bracket/dot access, liquid tag, and multiline if#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add specs for include bracket/dot access, liquid tag, and multiline if
Adds 60 new recorded test specs across three new spec files, covering edge cases and parity tests for three areas of the Liquid spec.
New spec files
specs/liquid_ruby/include_bracket_dot.yml (5 specs)
Covers {% include %} with bracket and dot notation in argument expressions, e.g. data[config.key].values. Also includes or conditions combined with blank/empty comparisons.
specs/liquid_ruby/liquid_tag.yml (48 specs)
Comprehensive parity tests for the {% liquid %} tag, covering the full range of constructs that can appear inside it:
specs/liquid_ruby/multiline_if.yml (7 specs)
Tests for multi-condition if expressions with mixed and/or operators, including comparisons and deep property lookups (e.g. a.b.c).