This repository was archived by the owner on May 15, 2024. It is now read-only.
Remove slack channels from service manifest #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration of service Slack channels has recently changed. Service Slack channels are no longer configurable in the `service.yml` manifest file. Instead, you can easily manage slack channels directly in Services Next. As such, this pull request removes the `slack_channels` key from the `service.yml` file. Please note that service Slack channels should be configured for operational purposes. Meaning, anything related to the operations of the service. For example, deploy notifications, failover notifications, and Bugsnags. Your team and help Slack channels should be configured in the Vault on your team page. They will also appear in Services Next for each owner of the service. Please go to Services Next and review the operational Slack channels of your services. Use the `Edit` button to correct them if needed. The `service.yml` changes in this pull request were generated programmatically, so it may have accidentally deleted comments or aliases. Feel free to touch up the pull request to match whatever style you'd like before merging.
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration of service Slack channels has recently changed. Service Slack channels are no longer configurable in the
service.ymlmanifest file. Instead, you can easily manage slack channels directly in Services Next. As such, this pull request removes theslack_channelskey from theservice.ymlfile.Please note that service Slack channels should be configured for operational purposes. Meaning, anything related to the operations of the service. For example, deploy notifications, failover notifications, and Bugsnags.
Your team and help Slack channels should be configured in the Vault on your team page. They will also appear in Services Next for each owner of the service.
Please go to Services Next and review the operational Slack channels of your services. Use the
Editbutton to correct them if needed.The
service.ymlchanges in this pull request were generated programmatically, so it may have accidentally deleted comments or aliases. Feel free to touch up the pull request to match whatever style you'd like before merging.