Remove some deprecated dependencies#6918
Remove some deprecated dependencies#6918gonzaloriestra wants to merge 3 commits intofix-peer-dependencies-issuesfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f6552e9 to
08f4907
Compare
08f4907 to
e5365bc
Compare
Coverage report
Test suite run success3788 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from 24611bb |
e5365bc to
51ac217
Compare
29e8fd1 to
26b8e23
Compare
131e313 to
dfd3d96
Compare
26b8e23 to
424e237
Compare
424e237 to
b6c765d
Compare
dfd3d96 to
24611bb
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
| outputDebug(outputContent`Removing directory at ${outputToken.path(path)}...`) | ||
| await del(path, {force: options.force}) | ||
| await fsRm(path, {recursive: true, force: options.force ?? false}) | ||
| } |
There was a problem hiding this comment.
rmdir() behavior change may break callers (non-empty dirs, error semantics)
The implementation of rmdir changed from del(path, {force}) to fs.promises.rm(path, {recursive: true, force: options.force ?? false}).
This is not equivalent:
del()is a glob-aware deletion library and historically has different semantics (it will delete contents via globbing and tends to “just work” even with tricky path patterns).fs.rm(..., {recursive:true})has stricter Node/filesystem semantics and can throw in casesdelmay have handled (permissions, readonly files on Windows, symlinks, etc.).- Also,
forcedefault is now effectivelyfalse(unless passed), which can change behavior vs prior usage if any callers relied ondelbeing more forgiving.
Impact: Could cause CLI operations that clean up temp/build directories to fail unexpectedly (especially on Windows), leaving stale directories behind, breaking follow-up steps (installs/builds), or causing flaky CI/feature tests.
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 1 findings 📋 History✅ 1 findings |

WHY are these changes introduced?
There's a warning about
@shopify/function-runnerand some subdependencies being deprecated:WHAT is this pull request doing?
Removes
@shopify/function-runner(unused) and a few subdependencies:How to test your changes?
pnpm installMeasuring impact
How do we know this change was effective? Please choose one:
Checklist