Skip to content

Remove some deprecated dependencies#6918

Open
gonzaloriestra wants to merge 3 commits intofix-peer-dependencies-issuesfrom
fix-deprecated-dependencies
Open

Remove some deprecated dependencies#6918
gonzaloriestra wants to merge 3 commits intofix-peer-dependencies-issuesfrom
fix-deprecated-dependencies

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Mar 2, 2026

WHY are these changes introduced?

There's a warning about @shopify/function-runner and some subdependencies being deprecated:

❯ pnpm install
Scope: all 14 workspace projects
packages/app                             |  WARN  deprecated @shopify/function-runner@4.1.1
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-i18n@7.14.0
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
 WARN  19 deprecated subdependencies found: @babel/plugin-proposal-class-properties@7.18.6, @babel/plugin-proposal-object-rest-spread@7.20.7, @shopify/dates@2.1.1, @shopify/function-enhancers@3.1.0, @shopify/i18n@2.1.0, @shopify/name@1.3.0, @shopify/react-effect@5.2.0, @shopify/react-hooks@4.1.2, @shopify/useful-types@5.3.0, abab@2.0.6, boolean@3.2.0, domexception@4.0.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, rimraf@3.0.2, whatwg-encoding@2.0.0
Packages: +1
+
Progress: resolved 2005, reused 1855, downloaded 0, added 1, done
Done in 2.7s using pnpm v10.11.1

WHAT is this pull request doing?

Removes @shopify/function-runner (unused) and a few subdependencies:

❯ pnpm install
Scope: all 14 workspace projects
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-i18n@7.14.0
 WARN  14 deprecated subdependencies found: @shopify/dates@2.1.1, @shopify/function-enhancers@3.1.0, @shopify/i18n@2.1.0, @shopify/name@1.3.0, @shopify/react-effect@5.2.0, @shopify/react-hooks@4.1.2, @shopify/useful-types@5.3.0, boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +12
++++++++++++
Progress: resolved 1991, reused 1841, downloaded 0, added 1, done
Done in 3.8s using pnpm v10.11.1

How to test your changes?

pnpm install

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

gonzaloriestra commented Mar 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gonzaloriestra gonzaloriestra changed the title Remove some deprecated subdependencies Remove some deprecated dependencies Mar 2, 2026
@gonzaloriestra gonzaloriestra mentioned this pull request Mar 2, 2026
5 tasks
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from f6552e9 to 08f4907 Compare March 2, 2026 11:38
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from 08f4907 to e5365bc Compare March 2, 2026 11:49
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.91% 14518/18876
🟡 Branches 70.63% 7221/10224
🟡 Functions 75.93% 3693/4864
🟡 Lines 78.42% 13717/17491

Test suite run success

3788 tests passing in 1448 suites.

Report generated by 🧪jest coverage report action from 24611bb

@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from e5365bc to 51ac217 Compare March 2, 2026 12:03
@gonzaloriestra gonzaloriestra force-pushed the fix-peer-dependencies-issues branch from 29e8fd1 to 26b8e23 Compare March 2, 2026 14:47
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch 2 times, most recently from 131e313 to dfd3d96 Compare March 3, 2026 10:49
@gonzaloriestra gonzaloriestra force-pushed the fix-peer-dependencies-issues branch from 26b8e23 to 424e237 Compare March 3, 2026 10:49
@gonzaloriestra gonzaloriestra force-pushed the fix-peer-dependencies-issues branch from 424e237 to b6c765d Compare March 3, 2026 15:49
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from dfd3d96 to 24611bb Compare March 3, 2026 15:49
@gonzaloriestra gonzaloriestra marked this pull request as ready for review March 4, 2026 11:43
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner March 4, 2026 11:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

outputDebug(outputContent`Removing directory at ${outputToken.path(path)}...`)
await del(path, {force: options.force})
await fsRm(path, {recursive: true, force: options.force ?? false})
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rmdir() behavior change may break callers (non-empty dirs, error semantics)

The implementation of rmdir changed from del(path, {force}) to fs.promises.rm(path, {recursive: true, force: options.force ?? false}).

This is not equivalent:

  • del() is a glob-aware deletion library and historically has different semantics (it will delete contents via globbing and tends to “just work” even with tricky path patterns).
  • fs.rm(..., {recursive:true}) has stricter Node/filesystem semantics and can throw in cases del may have handled (permissions, readonly files on Windows, symlinks, etc.).
  • Also, force default is now effectively false (unless passed), which can change behavior vs prior usage if any callers relied on del being more forgiving.

Impact: Could cause CLI operations that clean up temp/build directories to fail unexpectedly (especially on Windows), leaving stale directories behind, breaking follow-up steps (installs/builds), or causing flaky CI/feature tests.

@binks-code-reviewer
Copy link

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - 1 findings

📋 History

✅ 1 findings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant