Skip to content

Upgrade TypeScript to 5.9.3 #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
+160 −314
Open

Upgrade TypeScript to 5.9.3 #6897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@shopify/generate-docs": "0.15.6",
"@types/node": "18.19.70",
"@types/tmp": "^0.2.5",
"@typescript-eslint/parser": "8.33.0",
"@typescript-eslint/parser": "8.56.1",
"@vitest/coverage-istanbul": "^3.1.4",
"ansi-colors": "^4.1.3",
"bugsnag-build-reporter": "^2.0.0",
Expand All @@ -77,7 +77,7 @@
"rimraf": "^3.0.2",
"tmp": "^0.2.5",
"ts-node": "^10.9.1",
"typescript": "5.8.3",
"typescript": "5.9.3",
"vitest": "^3.1.4",
"zod": "^3.24.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/bulk-operations/stage-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ async function uploadFileToStagedUrl(
form.append(param.name, param.value)
}

form.append('file', new Blob([fileContents], {type: 'text/jsonl'}), filename)
form.append('file', new Blob([new Uint8Array(fileContents)], {type: 'text/jsonl'}), filename)
Copy link
Contributor Author

@gonzaloriestra gonzaloriestra Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript 5.9 no longer accepts Buffer as a valid BlobPart. Wrapping in new Uint8Array() satisfies the stricter type check with no runtime cost, since Buffer extends Uint8Array.


const uploadResponse = await renderSingleTask({
title: outputContent`Uploading bulk operation variables`,
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-plugin-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"dependencies": {
"@babel/core": "7.27.4",
"@shopify/eslint-plugin": "50.0.0",
"@typescript-eslint/eslint-plugin": "8.33.0",
"@typescript-eslint/parser": "8.33.0",
"@typescript-eslint/eslint-plugin": "8.56.1",
"@typescript-eslint/parser": "8.56.1",
"eslint-config-prettier": "10.1.5",
"eslint-plugin-jsdoc": "50.7.1",
"eslint-plugin-jsx-a11y": "6.10.2",
Expand Down
Loading
Loading