Upstream 2025-09-24

[aphelionz]

No description provided.

[Copilot]

Pull Request Overview

This is an upstream sync pull request that brings in changes from the main branch dated 2025-09-24. The changes include significant updates to the Zcash ecosystem integration, state management improvements, and various bug fixes and enhancements.

• Migrated from deprecated jubjub::Fq types to sapling_crypto types throughout the codebase
• Added non-finalized state backup and restore functionality for improved crash recovery
• Enhanced RPC functionality with new methods and improved parameter handling
• Updated network configuration handling for regtest parameters

Reviewed Changes

Copilot reviewed 183 out of 190 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
zebra-state/src/service/non_finalized_state/backup.rs	New backup system for non-finalized state with cache management
zebra-rpc/src/methods.rs	Added getmempoolinfo RPC method and improved address parameter handling
zebra-chain/src/sapling/	Migrated from jubjub::Fq to sapling_crypto types for better compatibility
zebra-state/src/service.rs	Async state initialization and backup integration
zebra-network/src/config.rs	Enhanced testnet parameter configuration with checkpoints support
zebra-consensus/src/checkpoint/	Refactored checkpoint handling to use shared types from zebra-chain

Files not reviewed (2)

• Cargo.lock: Language not supported
• zebra-rpc/proto/generated/zebra.indexer.rpc.rs: Language not supported

Comments suppressed due to low confidence (6)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[aphelionz]

27 Jobs Failed:

Crosslink Tests / Crosslink Tests failed on "Run Crosslink tests with nextest"

[...]
       P  EXPECT_POW_BLOCK_FINALITY (022b456214f1f9e61f3179d03ddda8c1121758f951ad69ae347593bc651aefe3 => Some(Finalized))
       P  EXPECT_POW_BLOCK_FINALITY (049cb29e28e0384d45faf4b03c9bd751d849dbdb9cefb1963abcbee21594079d => Some(Finalized))
       P  EXPECT_POW_BLOCK_FINALITY (04bb7e2b39579c03d7fffd305cb20c322334e8defb9a1917ca94515d8a804007 => Some(Finalized))
       P  EXPECT_POW_BLOCK_FINALITY (02d430420d69cac8c173eb6b0dbed0b3bc3aea592f8b44dbcfe63bc898e906a2 => Some(Finalized))
       P  EXPECT_POW_BLOCK_FINALITY (067099ef090558ef999334f2e8d9dc0c1444c6dce1e43aa9d1fc931643285447 => Some(NotYetFinalized))
       P  EXPECT_POW_BLOCK_FINALITY (05cece8a06debcead1eb3e9f121b0042007f962fa975b2dd1501c8b6612c551b => Some(NotYetFinalized))
       P  EXPECT_POW_BLOCK_FINALITY (04cd46683cd0963a160feba912b58c5556ffc2c015f85f09a849ffae49b75dc8 => Some(NotYetFinalized))
       P  EXPECT_POW_BLOCK_FINALITY (036ba69a9531f8897089edc6d32b570ad589b17d55f1f26873a07321a9ce75f2 => Some(NotYetFinalized))

    (test aborted with signal 6: SIGABRT)

────────────
     Summary [   7.357s] 15 tests run: 10 passed, 5 failed, 900 skipped
     SIGABRT [   7.150s] zebrad::crosslink crosslink_expect_pos_height_after_push
     SIGABRT [   7.036s] zebrad::crosslink crosslink_push_example_pow_chain_again_should_not_change_the_pow_chain_length
     SIGABRT [   7.168s] zebrad::crosslink crosslink_push_example_pow_chain_each_block_twice
     SIGABRT [   3.925s] zebrad::crosslink crosslink_push_example_pow_chain_only
     SIGABRT [   4.087s] zebrad::crosslink crosslink_test_basic_finality
error: test run failed
Error: Process completed with exit code 100.

26 jobs failed running on non-Blacksmith runners.

---

Summary: 3 successful workflows, 5 failed workflows

• ❌ Crosslink Tests (2 jobs succeeded, 1 job failed)
• ✅ Release on push to main (6 jobs succeeded)
• ✅ Deploy mdBook site to Pages (1 job succeeded)
• ❌ Unit Tests (5 jobs failed)
• ❌ Test Docker Config (2 jobs failed)
• ❌ Test Crate Build (1 job succeeded, 2 jobs failed)
• ❌ Lint (2 jobs succeeded, 17 jobs failed)
• ✅ Deploy Nodes to GCP (1 job succeeded)

Last updated: 2025-09-25 01:15:33 UTC