cython: list in setup_requires instead of install_requires#1031
Open
haampie wants to merge 1 commit intoSheffieldML:develfrom
Open
cython: list in setup_requires instead of install_requires#1031haampie wants to merge 1 commit intoSheffieldML:develfrom
haampie wants to merge 1 commit intoSheffieldML:develfrom
Conversation
MartinBubel
reviewed
Mar 26, 2024
Contributor
MartinBubel
left a comment
MartinBubel
left a comment
There was a problem hiding this comment.
Hi @haampie
thank you for the contribution. LGTM.
However, we are looking to remove the precompiled c files from the builds such that they are build when pip install'ing the lib.
I have not tested it yet but to my understanding, that would require to keep cython as an install requirement.
Would you agree?
This is why I am not sure if we should merge this, being only that change, as it may change again before the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can see, it's not a runtime dependency.