Skip to content

Conversation

@gvzdv
Copy link
Contributor

@gvzdv gvzdv commented Aug 27, 2025

Resolves #1143.

If any of the stage labels is empty, the preprocessor will return 204.
This prevents running most of the multistage-diagram-segmentation steps on non-diagram graphics and incomplete diagrams.

Tested on Unicorn with non-diagram graphics.


Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue.
  • I described how I tested these changes.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@gvzdv
Copy link
Contributor Author

gvzdv commented Aug 28, 2025

Good for now. We should revisit to make sure we're not excluding valid diagrams if we're missing one or two labels.

Future enhancement: experiment with letting the model assign the label if it's missing in the diagram (after we update categorization).

@gvzdv gvzdv merged commit d3d0f5b into main Aug 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return 204 if only empty labels are produced by multistage diagram preprocessor

3 participants