[dotnet] Fix generated devtools inline docs (amp;)

[nvborisenko]

Fix build warnings.

💥 What does this PR do?

This pull request makes a minor update to the ProtocolDefinitionItem class to improve how special characters are handled in descriptions.

• Improved HTML encoding in the Description property by also replacing & with & in addition to < and >, ensuring better safety and correctness in rendered output.

🔄 Types of changes

• Bug fix (backwards compatible)

[qodo-code-review]

PR Type

Bug fix

---

Description

• Fix HTML encoding in DevTools documentation by adding ampersand replacement

• Prevent malformed XML/HTML in generated inline documentation

• Improve special character handling in ProtocolDefinitionItem descriptions

---

File Walkthrough

Relevant files

Bug fix

ProtocolDefinitionItem.cs Add ampersand HTML encoding to Description property            third_party/dotnet/devtools/src/generator/ProtocolDefinition/ProtocolDefinitionItem.cs Added .Replace("&", "&") to the Description property getter Ensures ampersands are properly HTML-encoded alongside existing < and > replacements Prevents XML/HTML parsing issues in generated documentation Reformatted chained Replace calls for better readability +4/-1

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Incorrect encoding order: The new replacement chain encodes & after converting </> to &lt;/&gt;, causing double-encoding (e.g., &lt; becomes &amp;lt;) and incorrect output for common edge cases. Referred Code get => InitialDescription? .Replace("<", "&lt;") .Replace(">", "&gt;") .Replace("&", "&amp;"); Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Broken HTML sanitization: The manual HTML encoding is implemented in an unsafe order (& encoded last), resulting in double-encoding and incorrect sanitization of user-controlled content in Description. Referred Code get => InitialDescription? .Replace("<", "&lt;") .Replace(">", "&gt;") .Replace("&", "&amp;"); Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Fix HTML entity encoding order Suggestion Impact: The commit reordered the Replace calls to encode '&' first and removed the trailing ampersand replacement, addressing the double-encoding issue. code diff: get => InitialDescription? + .Replace("&", "&amp;") .Replace("<", "&lt;") - .Replace(">", "&gt;") - .Replace("&", "&amp;"); + .Replace(">", "&gt;"); Fix a double-encoding bug by reordering the Replace method calls. The ampersand character & should be replaced first. third_party/dotnet/devtools/src/generator/ProtocolDefinition/ProtocolDefinitionItem.cs [14-17] get => InitialDescription? + .Replace("&", "&amp;") .Replace("<", "&lt;") - .Replace(">", "&gt;") - .Replace("&", "&amp;"); + .Replace(">", "&gt;"); [Suggestion processed] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a bug in the PR where replacing & after other entities causes double-encoding, and provides a correct fix by reordering the Replace calls.	Medium
Update

[Copilot]

Pull request overview

This PR aims to fix build warnings and improve correctness of generated .NET DevTools inline documentation by ensuring special characters in protocol descriptions are properly escaped.

Changes:

• Updated ProtocolDefinitionItem.Description escaping to additionally handle & characters.
• Reformatted the Description getter into a multi-line chained replacement for readability.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.