report language version to plausible #16733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selenium-ci
added
C-py
Contributor
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||||||||
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
diemol
approved these changes
Dec 16, 2025
titusfortner
force-pushed
the
lang_version
branch
from
27f55ff to
d441159
Compare
nvborisenko
requested changes
Dec 17, 2025
Member
nvborisenko
left a comment
nvborisenko
left a comment
There was a problem hiding this comment.
Please elaborate motivation, and most likely we propose good solution in .NET. CC @RenderMichael
Member
Author
|
@nvborisenko The reason for the PR is specifically Java, if 50% of our users are still on Java 11, then we aren't going to want to require a move to Java 17, etc For .NET this means seeing how many people are still using .NET Framework vs NET 6/7 vs NET 8/9/10 |
| argsBuilder.Append($" --language-version netstandard2.0/{Environment.Version.Major}"); | ||
| #elif NET462 | ||
| argsBuilder.Append(" --language-version net462"); | ||
| #endif |
Contributor
There was a problem hiding this comment.
Would be nice to add at the end here, so we don’t forget to update this if necessary
#else
#error Add support here
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Note: this PR includes the code from #16736 to get the tests to pass
🔗 Related Issues
Implements #16731
💥 What does this PR do?
Each language obtains version to send to selenium manager
Selenium Manager reports to Plausible
🔧 Implementation Notes
The only nonstandard one is that .NET reports both the target framework and the Runtime Version:
🔄 Types of changes
PR Type
Enhancement
Description
Add language version reporting to Selenium Manager across all bindings
Java reports runtime feature version via Runtime.version().feature()
.NET reports target framework and runtime version with conditional compilation
JavaScript reports Node.js version via process.versions.node
Python reports major.minor version via sys.version_info
Ruby reports version via RUBY_VERSION constant
Rust infrastructure updated to parse and forward language-version argument
Diagram Walkthrough
File Walkthrough
10 files
Add Java runtime version reportingAdd .NET framework and runtime version reportingAdd Node.js version reportingAdd Python version reportingAdd Ruby version reportingAdd language_binding_version field to configAdd getter/setter for language binding versionAdd language-version CLI argument parsingAdd lang_version to stats metadata structuresAdd lang_version field to Props struct