Fix the behavior of GSL::Sf:gamma_inc and gsl mode selection for all special functions.#48
Open
jzakrzew wants to merge 3 commits intoSciRuby:masterfrom
Open
Fix the behavior of GSL::Sf:gamma_inc and gsl mode selection for all special functions.#48jzakrzew wants to merge 3 commits intoSciRuby:masterfrom
jzakrzew wants to merge 3 commits intoSciRuby:masterfrom
Conversation
added 3 commits
September 23, 2017 15:28
…functions. * Reduce code duplication by factoring out the mode selection code into its own function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a typo that caused GSL::Sf::gamma_inc to compute gamma_inc_P. Additionally, it adds a test for "natural form" variants of special functions that would have detected this issue earlier.
To make the test actually pass I had to go down the rabbit hole and fix the handling of the mode argument which was totally broken for several rb_gsl_sf_eval* functions. While at it, I refactored the mode selection code into its own function, instead of it being duplicated everywhere.