Added ConstantVoltage and ConstantCurrent#379
Closed
matthew-kapp wants to merge 3 commits intoSciML:mainfrom
Closed
Added ConstantVoltage and ConstantCurrent#379matthew-kapp wants to merge 3 commits intoSciML:mainfrom
matthew-kapp wants to merge 3 commits intoSciML:mainfrom
Conversation
Contributor
|
We don't have these kind of components in mtkstdlib, instead we compose a Constant with a Voltage component, I.e., we separate the signal shape from the domain in order to avoid having to introduce the Cartesian product of all signal shapes and physical domains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
It can be irritating to add a constant source block and connect to a voltage as opposed to just providing a voltage value parameter. Same for current.