Hydraulic docstrings updated to match code#362
Hydraulic docstrings updated to match code#362matthew-kapp wants to merge 3 commits intoSciML:mainfrom matthew-kapp:main
Conversation
- updated docstrings in utils.jl to remove P_int (in docstrings) - updated docstrings in sources.jl to remove P_int (in docstrings) - updated docstrings in components.jl to remove P_int, P_a_int, etc (in docstrings) - solves issue #354
…tStandardLibrary.jl into change-readme I forgot to first sync and pull before adding changes
Hydraulic docstrings updated to match code - updated docstrings in utils.jl to remove P_int (in docstrings) - updated docstrings in sources.jl to remove P_int (in docstrings) - updated docstrings in components.jl to remove P_int, P_a_int, etc (in docstrings) - solves issue #354
|
There were quite a few errors when I ran docs/make, unrelated to my changes. Is this relevant i.e. do these errors need to be fixed first? |
|
Doesn't the macro generate inits for each of the variables? |
|
I don't know, so is it correct the way it is? |
|
@ven-k ? |
|
Hydraulic library was not written with The julia> @macroexpand1 @mtkmodel A begin
@variables begin
v
end
end
:(A = (ModelingToolkit.Model)($(Expr(:(=), :(__A__(; name,
v::Union{Nothing, Missing, ModelingToolkit.NoValue, Real} = ModelingToolkit.NoValue())), quote
...
... |
|
Apologies for my Github clumsiness @ChrisRackauckas @ven-k If the updates are OK, could you please approve PR #367 once it is ready? |
|
This was closed? |
|
@ChrisRackauckas @ven-k these updates were combined with PR #363 |
|
And I closed it by mistake |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context