Conversation
Member
|
The initial Jacobian is singular, the initialization solution has an index-2 DAE at the starting point of the time stepping. Main.LinearAlgebra.cond(W) = 1.9507933081280378e12
Main.LinearAlgebra.cond(W) = 1.8757802497588914e12
Main.LinearAlgebra.cond(W) = 1.9100754482497002e12
Main.LinearAlgebra.cond(W) = 1.9291032293541746e12
Main.LinearAlgebra.cond(W) = 1.9449040001602686e12
Main.LinearAlgebra.cond(W) = 1.956880525752231e12
Main.LinearAlgebra.cond(W) = 1.8642642846288142e12
Main.LinearAlgebra.cond(W) = 1.8840317888731355e12
Main.LinearAlgebra.cond(W) = 1.896847421636734e12
Main.LinearAlgebra.cond(W) = 1.925558550278289e12
Main.LinearAlgebra.cond(W) = 1.8469820435050667e12
Main.LinearAlgebra.cond(W) = 1.873127333970352e12
Main.LinearAlgebra.cond(W) = 1.85940822577763e12
Main.LinearAlgebra.cond(W) = 1.9505801274429348e12
Main.LinearAlgebra.cond(W) = 1.9439521531702615e12
Main.LinearAlgebra.cond(W) = 1.9630631453906282e12 |
Contributor
|
@ChrisRackauckas and @bradcarman - it looks like the hydraulics setting allow_symbolic to true cleared the hydraulics errors that showed up in Chris' check. There were questions about whether or not this method will scale though - making its use for a library questionable. |
Contributor
Author
|
|
Member
|
@matthew-kapp Can you look at updating this one? Your change to macros is what's blocking this PR, so this needs to be merged with that change. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Implements the following changes:
regPowp(rho)in place ofrho(p)to enable Rodas5P adaptive solving, seeRodas5PGoes unstable with an increase inabstolOrdinaryDiffEq.jl#2561Note: a new version release is needed,
DynamicVolumefunction has changed, removing theNinput because discretization is not possible with the Initialization System and solving with Rodas5P. This was an advanced feature that can be added back in the proper way with a future research project.