Simplify temperature dependency for analog components#349
Simplify temperature dependency for analog components#349langestefan wants to merge 3 commits intoSciML:mainfrom
Conversation
|
Looks like there's a QA test failure? Other than that it looks good to go. |
|
@ChrisRackauckas @langestefan Is this a new fail or an existing fail. I get the following error during test on main (no changes):
|
|
This PR is not merged so it's not related. |
|
Can you rebase this? It would be easier to see it against main which now has some more fixed tests. |
I see some things are failing due to Perhaps we could setup a proper pre-commit flow to catch these sorts of things at the development side. |
|
@langestefan could you please remove 'unit =' and just have the 'description ='. I also don't quite understand the error, but I figured out this is the root cause of this and previous Aqua/QA failures (Unbound Error). |
Yes I saw that as well. Should be fixed now. There should still be CI failures but they should not be related to this PR. |
|
It looks like lots of new tests are failing here? |
|
None of those seem to have anything to do with this PR? For example I see: and: are these new tests that were never run? |
|
@langestefan @ChrisRackauckas I have raised this Issue #371 . It seems the root cause is Symbolics update braking. |
|
This PR can be closed now due to #380 being merged |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This simplifies some of the component definitions, similar to how they are defined in Modelica.
For example, in Modelica the resistor has a
useHeatPortboolean argument which adds a temperature dependency.This means
HeatingDiodeandHeatingResistorcomponents are removed, butResistorandDiodenow incorporate optional temperature-dependent behavior. By default temperature dependency is disabled, soResistor(R=1.0)can be called as usual.