fix: make @poissonians return a Vector like @variables and @brownians#4274
Merged
AayushSabharwal merged 1 commit intoSciML:masterfrom Feb 8, 2026
Merged
Conversation
Previously @poissonians returned a bare Num for single declarations and a Tuple for multiple declarations. Now it always returns a Vector, consistent with @variables and @brownians which use Symbolics.parse_vars. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
@AayushSabharwal if relevant tests pass this should be good to go. It is a minor change to just be consistent with |
This was referenced Feb 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@poissoniansreturned inconsistent types compared to@variablesand@brownians:@variables/@brownians@poissonians(before)[x](1-elementVector)Num[x, y](Vector)(x, y)(Tuple)[x, y](Vector)NumorTupleThis happened because
@variablesand@browniansdelegate toSymbolics.parse_vars(which always returns aVectorviaExpr(:vect, ...)), while@poissoniansused custom codegen that returned a bare name for single declarations and anExpr(:tuple, ...)for multiple.Fix
One-line change in
_poissonians: replace the conditional bare/tuple return withExpr(:vect, names...)so it always returns aVector.No existing tests break since all current usages rely on the side effect of binding variables into scope, not on the return value. New tests verify the return type across all permutations (single/multiple, inline/block).