Downloads model weights for promptable sam and sam2 when user tries to use them first time#989
Merged
ElpadoCan merged 4 commits intoSchmollerLab:mainfrom Jan 29, 2026
Merged
Conversation
Add download logic to widgets.py selectModel() for segment_anything and sam2 promptable models, consistent with normal model workflow. Fixes SchmollerLab#986 - FileNotFoundError when using segment_anything promptable model for the first time because weights weren't downloaded. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add sam2_weights_filenames to __init__.py so check_model_exists() works correctly for SAM2. This ensures the download warning dialog appears before downloading SAM2 weights, consistent with other models. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Related to #986 |
Collaborator
|
Hi @keejkrej, thanks for doing this! One question, what is the reason of moving |
ElpadoCan
reviewed
Jan 29, 2026
ElpadoCan
reviewed
Jan 29, 2026
Remove the model name check so download is triggered for all promptable models, consistent with gui.py behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
keejkrej
force-pushed
the
fix/model_download
branch
from
47d8520 to
c57442c
Compare
ElpadoCan
approved these changes
Jan 29, 2026
Collaborator
|
Merged! Thanks again for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.