Add #ifNotNil:ifNil: to Nil and Object#123
Merged
smarr merged 3 commits intoSOM-st:masterfrom Feb 13, 2025
Merged
Conversation
Signed-off-by: Stefan Marr <[email protected]>
…bject to 33 Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This was referenced Feb 17, 2025
smarr
added a commit
to SOM-st/SOMpp
that referenced
this pull request
Feb 20, 2025
Adopts the changes of SOM-st/SOM#123 and SOM-st/SOM#124. This does not add any changes in SOM++ itself though. They are separate in #59.
This was referenced Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing selector for nil checks, with the first branch being the non-nil case. This is mostly for symmetry and convenience, since we already had the
#ifNil:ifNotNil:case.This change is relied on in the AreWeFastYet benchmarks with smarr/are-we-fast-yet#99.
Core-Lib Updates