Skip to content

Set null terminator after realloc #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajeshsingh381 wants to merge 1 commit into from
Closed

Set null terminator after realloc #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1986,6 +1986,7 @@ bool call::executeMessage(message *curmsg)
last_send_index = curmsg->index;
last_send_len = msgLen;
realloc_ptr = (char *) realloc(last_send_msg, msgLen+1);
realloc_ptr[msgLen] = '\0';
Copy link
Contributor

@orgads orgads Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does this fix? Isn't it done anyway in line 1997?

if (realloc_ptr) {
last_send_msg = realloc_ptr;
} else {
Expand Down