Skip to content

feat: [DevOps] Update document-grounding specification#826

Merged
rpanackal merged 4 commits intomainfrom
spec-update/document-grounding/main
Apr 15, 2026
Merged

feat: [DevOps] Update document-grounding specification#826
rpanackal merged 4 commits intomainfrom
spec-update/document-grounding/main

Conversation

@sap-ai-sdk-bot
Copy link
Copy Markdown
Contributor

@sap-ai-sdk-bot sap-ai-sdk-bot bot commented Apr 15, 2026

Context

Update document-grounding specification file based on main.

This PR was created automatically by the spec-update workflow.
You can commit on top of this branch, but as long as this PR is open the action can't be re-run.

  • Compilation outcome: success
  • Test run outcome: success

Before merging, make sure to update tests and release notes, if necessary.

Definition of Done

  • Unit tests cover new classes
  • Release notes updated

Copy link
Copy Markdown
Member

@rpanackal rpanackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗
The PR contains breaking changes that have already been released. Checkout Grounding PR for more information.

The SDK Code Generation workflow passed as there was no test coverage for the changes.

I also failed to find any spec update review/communication from the SDK side. Before merging this, we need to agree whether to accept the changes or not.

@rpanackal rpanackal closed this Apr 15, 2026
@rpanackal rpanackal deleted the spec-update/document-grounding/main branch April 15, 2026 10:34
@rpanackal rpanackal restored the spec-update/document-grounding/main branch April 15, 2026 10:35
@rpanackal rpanackal reopened this Apr 15, 2026
Copy link
Copy Markdown
Member

@rpanackal rpanackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to accept the current state since the changes has been already released on the Grounding Service and drafted BLIs to improve grounding test coverage.

Comment thread docs/release_notes.md
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
@rpanackal rpanackal merged commit 5a8097b into main Apr 15, 2026
7 checks passed
@rpanackal rpanackal deleted the spec-update/document-grounding/main branch April 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants