Fix: Prevent inf values in clicks/impressions when CPC/CPM becomes non-positive #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
simulate_mediato floor non-positive CPC/CPM to a small positive percentile-based value (prevents divide-by-zero andinfinlifetime_clicks/impressions when additive noise drives cost <= 0).infclicks for click channels.Issue #43
Solution
Modified
_negative_replace()to handle CPC/CPM columns specially:1e-6)