chore: remove unnecessary Default bound on T in hash_to_field #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bot? |
Contributor
Author
alive person |
Member
|
cc @daxpedda |
tarcieri
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the T: Default bound from hash2curve/src/hash2field.rs::hash_to_field(), since T is only used via Reduce<Array<u8, L>> (T::reduce(&tmp)) and never instantiated with T::default(). The Reduce trait from elliptic_curve::ops does not require Default, and call sites rely solely on reduction from expanded message bytes. This change relaxes the generic constraints without altering behavior or API semantics. The Default bound in hash2curve/src/map2curve.rs is intentionally preserved because mapping implementations construct Array::<FieldElement, N>::default(), which requires FieldElement: Default.