pss: remove redundant verify_algorithm_id call in SigningKey::try_from#660
Open
VolodymyrBg wants to merge 1 commit intoRustCrypto:masterfrom
Open
pss: remove redundant verify_algorithm_id call in SigningKey::try_from#660VolodymyrBg wants to merge 1 commit intoRustCrypto:masterfrom
verify_algorithm_id call in SigningKey::try_from#660VolodymyrBg wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit [verify_algorithm_id()]
RSA/src/encoding.rs
Lines 152 to 169 in 1e94064
RsaPrivateKey::try_from()was redundant becauseRsaPrivateKey::try_from()already performs the samecheck internally. This matches the pattern used in [BlindedSigningKey]
RSA/src/pss/blinded_signing_key.rs
Lines 31 to 38 in 1e94064