refactor!: make SampleRate a u32 alias #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
For yet another level in this discussion we could change these types to be |
roderickvd
force-pushed
the
refactor/type-alias-sampleformat
branch
3 times, most recently
from
b9584ba to
62fe86d
Compare
roderickvd
force-pushed
the
refactor/type-alias-sampleformat
branch
from
62fe86d to
f11ed67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since forever
SampleRatehas been a newtypepub struct SampleRate(pub u32)without offering any further type guarantees or functionality. On the contraryFrameCountandChannelCountare just type aliases to some integer type.This PR changes
SampleRateto also be a type alias. While breaking, it'll be easier downstream.