Skip to content

Tidying up the project #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yukideluxe merged 3 commits into from
Jul 9, 2025
Merged

Tidying up the project #125

yukideluxe merged 3 commits into from
Jul 9, 2025

Conversation

@Nymuxyzo
Copy link
Contributor

@Nymuxyzo Nymuxyzo commented Jan 6, 2025

  • Old not maintained ruby removed
  • Gem version maintenance
  • Github workflow
  • Switch for an old version removed

@Nymuxyzo
Copy link
Contributor Author

Nymuxyzo commented May 26, 2025

Any opinions on this PR?

yukideluxe
yukideluxe previously approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@yukideluxe yukideluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve! thanks!

lib/eu_central_bank.rb
Money.new(money, to_currency)
end

def open_url(url)
Copy link
Member

@yukideluxe yukideluxe Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefkiss:

@Nymuxyzo @yukideluxe
Tidying up the project
b6baded 
- Old not maintained ruby removed
- Gem version maintenance
- Github workflow
- Switch for an old version removed
@yukideluxe
Copy link
Member

yukideluxe commented Jul 9, 2025 •
edited
Loading

@Nymuxyzo I rebased with branch with main (I didn't know I could do that 😬) to trigger the GH actions but I think we must include the bigdecimal gem in the Gemfile now!

@Nymuxyzo
Copy link
Contributor Author

Nymuxyzo commented Jul 9, 2025 •
edited
Loading

@Nymuxyzo I rebased with branch with main (I didn't know I could do that 😬) to trigger the GH actions but I think we must include the bigdecimal gem in the Gemfile now!

@yukideluxe thank you for your help and you are absolutely right

yukideluxe
yukideluxe reviewed Jul 9, 2025
View reviewed changes
.github/workflows/ruby.yml Outdated
strategy:
matrix:
ruby-version: ['2.6', '2.7', '3.0', '3.1', '3.2']
ruby-version: ["3.0", "3.1", "3.2", "3.3", "3.4"]
Copy link
Member

@yukideluxe yukideluxe Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are dropping 3.0, we should remove it from here too! otherwise the tests won't pass 😊 Almost there! 💪🏻

Copy link
Contributor Author

@Nymuxyzo Nymuxyzo Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had overlooked that. I'm about to have a crisis

Copy link
Member

@yukideluxe yukideluxe Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look, it's all green now! 😊

yukideluxe
yukideluxe approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@yukideluxe yukideluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great! 🙏🏻 I'll add a line in the CHANGELOG mentioning that we dropped support for Ruby 3.0 💪🏻

@yukideluxe yukideluxe merged commit 516b1dd into RubyMoney:main Jul 9, 2025
4 checks passed
@Nymuxyzo Nymuxyzo deleted the tech/housekeeping branch July 9, 2025 18:37
@yukideluxe yukideluxe mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yukideluxe yukideluxe yukideluxe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nymuxyzo @yukideluxe