Skip to content

Conversation

@lczech
Copy link

@lczech lczech commented Jul 30, 2025

Following up on #329 (comment)

This PR is just the result of calling clang-format -i *.hpp and clang-format -i *.cpp in the source directory, with clang format v18.1.3 on Ubuntu 24.

@lyskov
Copy link
Member

lyskov commented Aug 20, 2025

Thank you @lczech ! The diff set looks a bit off (should be just a few changes at best since last merge to master), - maybe merge-in latest master?

@lczech
Copy link
Author

lczech commented Aug 20, 2025

This PR is based on commit 46ec0e8 from May 20th, which at the time was the latest on master. It seems now that you added a commit 396bce5 yourself which also applies clang format - so I guess this PR here can be closed then?

@lyskov
Copy link
Member

lyskov commented Aug 20, 2025

Yes, - sorry about that! I reformatted and merged before I saw your PR. Probably best to close this for now. Please feel free to re-open if you still see local diffs after reformatting.

@lyskov lyskov closed this Aug 20, 2025
@lyskov lyskov reopened this Aug 20, 2025
@lczech
Copy link
Author

lczech commented Aug 20, 2025

Sure, thanks! Now you closed and immediately re-opened this. Shall we close it? Or what is your plan?

@lyskov
Copy link
Member

lyskov commented Aug 21, 2025

🤦‍♂️ - yes, please close (ie it is your PR)

@lczech lczech closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants