Skip to content

fix: message fail to deliver in non e2e channel#7067

Draft
Rohit3523 wants to merge 1 commit intodevelopfrom
mobile_message_delivery_failure
Draft

fix: message fail to deliver in non e2e channel#7067
Rohit3523 wants to merge 1 commit intodevelopfrom
mobile_message_delivery_failure

Conversation

@Rohit3523
Copy link
Copy Markdown
Contributor

@Rohit3523 Rohit3523 commented Mar 26, 2026

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-994

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@Rohit3523 Rohit3523 requested a deployment to approve_e2e_testing March 26, 2026 14:33 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to official_android_build March 26, 2026 14:37 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build March 26, 2026 14:37 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build March 26, 2026 14:37 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 requested a deployment to official_ios_build March 26, 2026 14:37 — with GitHub Actions Waiting
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc78907e-8b56-4605-ae2e-0da4700529a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 requested a deployment to upload_experimental_android March 26, 2026 15:45 — with GitHub Actions Waiting
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Android Build Available

Rocket.Chat Experimental 4.71.0.108436

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTY2NKKz-G8xL2VIxJpHP7d59yskqisUtuNKfjNg9Q2P1moytFnnx05I_VxKw8BvZiR73TyVwugf-5CGNk8

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

iOS Build Available

Rocket.Chat Experimental 4.71.0.108437

diegolmello
diegolmello reviewed Mar 27, 2026
View reviewed changes
app/lib/encryption/encryption.ts
const roomE2E = await this.getRoomInstance(rid);
if (!roomE2E || !roomE2E?.hasSessionKey()) {
return;
return message;
Copy link
Copy Markdown
Member

@diegolmello diegolmello Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have tests for this besides e2e ones, but we need to test this very carefully not to introduce regressions.
There's probably a reason that return is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rohit3523 @diegolmello