feat: add canvas as option to Viewer constructor#549
Closed
haoming29 wants to merge 1 commit intoRobotWebTools:developfrom
Closed
feat: add canvas as option to Viewer constructor#549haoming29 wants to merge 1 commit intoRobotWebTools:developfrom
haoming29 wants to merge 1 commit intoRobotWebTools:developfrom
Conversation
Contributor
|
Please resolve the conflicts. So that CI can run |
Author
|
Closed with #584 open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Viewer constructor now accept
canvasas an option in the parameter optionsDescription
Add canvas as the parameter to the Viewer constructor so that user can pass OffscreenCanvas to ROS 3D for performance improvement
#546