Prebuildify

[minggangw]

No description provided.

[Copilot]

Pull Request Overview

This PR implements prebuildify support for rclnodejs, enabling prebuilt native binaries for faster installation and deployment. The changes also vendor the ref-napi dependency and create a custom native module loader to handle prebuilt binaries with exact environment matching.

• Integrates prebuildify to generate prebuilt native binaries tagged with Ubuntu codename and ROS2 distribution
• Vendors ref-napi dependency to eliminate external dependency conflicts
• Implements custom native loader with exact environment matching for prebuilt binaries

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
package.json	Adds prebuildify dependency and prebuild npm script
scripts/tag-prebuilds.js	Script to tag prebuilt binaries with Ubuntu/ROS2 specific information
lib/native_loader.js	Custom loader for prebuilt binaries with fallback to source compilation
third_party/ref-napi/	Vendored copy of ref-napi dependency with integration bindings
binding.gyp	Updates build configuration for C++20 and ref-napi integration
.github/workflows/	CI workflows for generating prebuilt binaries on Linux x64/ARM64

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Debug console.log statement should be removed from production test code.

Suggested change

console.log(script);

[Copilot]

Commented out cleanup code should be removed or fixed. This will cause test artifacts to accumulate.

Suggested change

	// if (getNodeVersionInfo()[0] === 10) {
	// rimraf.sync(this.tmpPkg);
	// } else {
	// fs.rmSync(this.tmpPkg, { recursive: true });
	// }
	if (getNodeVersionInfo()[0] === 10) {
	rimraf.sync(tmpPkg);
	} else {
	fs.rmSync(tmpPkg, { recursive: true });
	}

[coveralls]

coverage: 83.204% (-1.1%) from 84.337%
when pulling b442efd on minggangw:prebuildify
into 8762f13 on RobotWebTools:develop.

[Copilot]

Pull Request Overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

third_party/ref-napi/src/ref_napi_bindings.cpp:1

• Corrected grammar in error message from 'no digits we found' to 'no digits were found'.

// Copyright (c) 2020 The ref-napi Authors.

third_party/ref-napi/src/ref_napi_bindings.cpp:1

• Corrected grammar in error message from 'no digits we found' to 'no digits were found'.

// Copyright (c) 2020 The ref-napi Authors.

third_party/ref-napi/src/ref_napi_bindings.cpp:1

• Corrected grammar in error message from 'no digits we found' to 'no digits were found'.

// Copyright (c) 2020 The ref-napi Authors.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Error message is misleading - this is in WriteObject function but says 'readObject'. Should be 'writeObject: Cannot write to nullptr pointer'.

Suggested change

	throw Error::New(env, "readObject: Cannot write to nullptr pointer");
	throw Error::New(env, "writeObject: Cannot write to nullptr pointer");

[Copilot]

Error message is inconsistent - this is in ReadInt32 function but says 'readInt64'. Should be 'readInt32: Cannot read from nullptr pointer'.

Suggested change

	throw TypeError::New(env, "readInt64: Cannot read from nullptr pointer");
	throw TypeError::New(env, "readInt32: Cannot read from nullptr pointer");

[minggangw]

Abandon as splitted into #1285 #1287