Please change this argument name "contentIdList" to something so it doesn't sound like direct ID input#1444
Open
karl-police wants to merge 1 commit intoRoblox:mainfrom
Open
Please change this argument name "contentIdList" to something so it doesn't sound like direct ID input#1444karl-police wants to merge 1 commit intoRoblox:mainfrom
karl-police wants to merge 1 commit intoRoblox:mainfrom
Conversation
github-actions
bot
added
engine reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please change this argument name "contentIdList" to something so it doesn't sound like direct ID input, array of string of rbxassetid please. I don't know, but I think there used to be an actual method that accepted a string directly, while this one is just instances which can hold ids.
Or the API itself doesn't throw if no instance is passed.
also seeking answer for this still: #1386 (comment)
and the other one was about the chat update being clarified in the docs, but I think that's confirmed to be WIP all over around the place