Bug fix and minimize functionality #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multitab support for docking
Modified TabMenuItem class in the skin.
Fix to get the title string rather than textProperty
When only one tab is left, convert to SplitContentPane.
Please, use DockNode.dock()/DockNode.undock() functions in order to keep the properties consistent.
Merge with the latest change set
This PR is necessary for new commit Halcyon@968e004b8c75b32a89142f2a18d024eea74c0c41
When a menubar is included, the proposed rectangle was wrongly located.
Merged FXML support from https://github.com/Kladimir/DockFX Hi @SamCooper, Thank you for the PR! It would be good to include FXML examples as well. I am sorry for my late action.
Add preference management for dock position/size
When it handle floating nodes, it should add the node in undockedNodes list.
Have to investigate it more.
…s not the main pane of the application.
Thank you so much, @SamCooper! This is the really good fix for handling dock windows better in certain constraints of pane.
->minimize only works when the DockNode is floating ->minimize calls iconify function -Fix a bug causing the docknode to disappear (Linux Mint 64 bits, java 8 Oracle) ->appears when the user drag a docknode outside, then maximize the floating node and maximize again the floating node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add minimize functionality
->minimize only works when the DockNode is floating
->minimize calls iconify function
-Fix a bug causing the docknode to disappear (Linux Mint 64 bits, java 8 Oracle)
->appears when the user drag a docknode outside, then maximize the floating node and maximize again the floating node