Initialize modern ui with avalonia#260
Open
tolgayilmaz86 wants to merge 11 commits intoRiddleTime:devfrom
Open
Initialize modern ui with avalonia#260tolgayilmaz86 wants to merge 11 commits intoRiddleTime:devfrom
tolgayilmaz86 wants to merge 11 commits intoRiddleTime:devfrom
Conversation
Author
|
|
Adds control panel buttons and ready to be filled
…xecution if necessary
Based on selected game load different Overlay settings view. Refactor game selection and UI components - Refactored `GameSelectionService` to use a singleton pattern with `Lazy<T>`, added `GameChanged` event, and improved game selection methods. - Cleaned up using directives in `MainTopMenuViewModel` and defined an asynchronous command for opening settings. - Updated `ControlButtonsPanelViewModel` to manage favorite icon color and overlay status, with improved command initialization. - Enhanced `OverlaysViewModel` to handle game-specific view models and respond to game changes. - Modified several XAML files to remove `ControlButtonsPanelView` and reorganize UI layout for better structure. - Updated `OverlaysPageView.axaml` to include a new column for global control buttons and adjusted code-behind for initialization.
dont messup with indexes Refactor overlay management and game selection system - Updated `GameSelectionService` to support nullable `GameChanged` events and removed the internal `SelectGame` method for a streamlined approach. - Introduced `OverlayType` enum in `OverlaySelectionService` to define overlay types with display attributes. - Implemented `OverlaySelectionService` as a singleton to manage overlay availability across games. - Enhanced `OverlaySettingViewModelBase` with new properties and event subscriptions for overlay availability. - Updated `OverlaysViewModel` to utilize `OverlayType` for improved type safety and clarity. - Modified XAML files for overlays to include display names and improved UI. - Replaced hardcoded overlay items in `OverlaysPageView` with dynamic data binding for better maintainability. - Added `EnumToIndexConverter` for converting between `OverlayType` enums and indices. - Ensured `OverlaysPageView.axaml.cs` reflects view model changes for control button updates. These changes significantly enhance the maintainability and user experience of the overlay management system.
RiddleTime
reviewed
Apr 16, 2025
|
|
||
| namespace RaceElement.UI.Services; | ||
|
|
||
| public enum SupportedGame |
Owner
There was a problem hiding this comment.
Might help you out a bit
https://github.com/RiddleTime/Race-Element/blob/dev/Race%20Element.Data/Games/Game.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have RaceElement.UI project which has modern ui prototype