Fix one more flaky test #5939
Draft
Fix one more flaky test #5939
+27
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
EventsManagerIntegrationTests.testPostingCustomerCenterDoesNotFail()was sometimes failing. E.g. here (even though it passed after 3 retries).This PR makes the test more deterministic by waiting for the execution of
Purchases.shared.track(customerCenterEvent: )to complete before checking the logs.In addition, the logs check is also more strict now, checking for the right event name + event identifier.
More details
I suspect the reason of the random failures is that
Task.yield()would not always wait for the track eventTasks to complete, resulting in the test checks happening before the expected logs actually happened.