Workaround to reduce the flakiness of some tests #5934
Draft
+172
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns from SKTestSession Trying to reduce the flakiness of failed tests in https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/32195/workflows/fda6c174-617d-44bd-a997-ad2a9a36de4d/jobs/421143/tests (`testDoesNotSyncExistingSK2Purchases()` and `testObservingTransactionUnlocksEntitlement()`)
This reverts commit 040446a.
…entify the transaction id and the source of that purchase This could help debugging flaky tests as sometimes we get a "Finishing transaction" log in a test that is actually finishing the transaction generated in a different test
…Tests`' `testPostsPurchasePerformedOnFallbackURLWhenRecoveringAfterRestartToMainServer()` By asserting the Finishing transaction log only against the actual expected transaction
…ngMultipleProductsWhileServerIsDownHandlesAllTransactionsWhenForegroundingApp()`
This reverts commit c11e904.
…ansactions from SKTestSession" This reverts commit eab98f6. # Conflicts: # Tests/StoreKitUnitTests/TestHelpers/StoreKitTestHelpers.swift
…ransactions from SKTestSession" This reverts commit 31741a7.
# Conflicts: # Tests/BackendIntegrationTests/Helpers/ExternalPurchasesManager.swift
ajpallares
force-pushed
the
workaround-to-reduce-some-tests-flakiness
branch
from
446f02e to
f468569
Compare
Danger has errored[!] Invalid Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StoreKitObserverModeIntegrationTests'testDoesNotSyncExistingSK2Purchases()andtestObservingTransactionUnlocksEntitlement()are sometimes failing.Recent failures here
I suspect the failures happen because, sometimes, changes to the
SKTestSessiondo not reflect immediately in StoreKit. The potential fix makes sure to double check that when deleting all transactions fromSKTestSession, StoreKit indeeds reflects it before continuing with the test execution.This hypothesis and the implemented workaround were greatly inspired by https://github.com/dropbox/StoreKitTestHelpers