Replace RCPurchasesErrorCodeDomain with ErrorCode.errorDomain in tests
#5924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@RCGitBot please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we get compilation errors in the tests targets like these:
The reason is that the
RCPurchasesErrorCodeDomainsymbol is not explicitly declared in the SDK. It's the Objective-C bridge ofErrorCode.errorDomainand is declared in the auto-generatedRevenueCat-Swift.hfile:But this
RevenueCat-Swift.hfile doesn't always necessarily exist.In particular, I got this error when adding the RevenueCat dependency to Unit Tests as a Swift Package using Tuist when working on #5888.
Description
This PR replaces the uses of
RCPurchasesErrorCodeDomainin tests with its Swift equivalent:ErrorCode.errorDomain, which is always defined.